Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Drop .NET 5.0 support, add .NET 9.0 support #584

Merged
merged 11 commits into from
Nov 22, 2024
Merged

[chore] Drop .NET 5.0 support, add .NET 9.0 support #584

merged 11 commits into from
Nov 22, 2024

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented Aug 16, 2024 •
edited
Loading

Description

  • Drop .NET 5.0 support for EasyPost library
    • Remove .NET 5.0 from target frameworks for library and test suites
    • Remove .NET 5.0 target framework and binaries from NuGet package build
    • Remove .NET 5.0 from CI
    • Remove .NET 5.0 installation via environment setup scripts
  • Add .NET 9.0 support
    • Add .NET 9.0 to target frameworks for library and test suites
      • Use .NET 9.0 for FSharp and VB compatibility check
    • Add .NET 9.0 target framework and binaries to NuGet package build
    • Add .NET 9.0 to CI
    • Add .NET 9.0 installation via environment setup scripts

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8
Copy link
Member Author

Good thing to know: Accidentally confirmed that even when .NET 5.0 is not explicitly listed as a target framework in the library, it did still run in a .NET 5.0 environment successfully. Given that we haven't made any framework-breaking changes, it's likely that our library will continue to work in .NET 5.0 (and probably .NET Core 3.1) even if we don't explicitly support/test it in those versions.

@nwithan8 nwithan8 force-pushed the drop_net5_support branch 2 times, most recently from ef26188 to fde4ba8 Compare November 18, 2024 20:56
@nwithan8 nwithan8 changed the title [chore] Drop .NET 5.0 support [chore] Drop .NET 5.0 support, add .NET 9.0 support Nov 18, 2024
@nwithan8 nwithan8 marked this pull request as ready for review November 18, 2024 21:41
@nwithan8 nwithan8 requested a review from a team as a code owner November 18, 2024 21:41
@nwithan8 nwithan8 merged commit a78d48e into master Nov 22, 2024
14 checks passed
@nwithan8 nwithan8 deleted the drop_net5_support branch November 22, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justintime50 Justintime50 Justintime50 approved these changes

@jchen293 jchen293 jchen293 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @jchen293 @Justintime50